Skip to content

CI: Fix import of coo_matrix after scipy dev upgrade #44344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

CI: Fix import of coo_matrix after scipy dev upgrade #44344

wants to merge 1 commit into from

Conversation

phofl
Copy link
Member

@phofl phofl commented Nov 7, 2021

New scipy_dev renamed coo to _coo to make it private

@phofl phofl added CI Continuous Integration Dependencies Required and optional dependencies labels Nov 7, 2021
@phofl
Copy link
Member Author

phofl commented Nov 7, 2021

Fixes the scipy affected tests. The numpy affected tests are still failing

@jbrockmendel
Copy link
Member

Best guess is this np.quantile PR numpy/numpy#18203 is causing the current build failures.

@phofl
Copy link
Member Author

phofl commented Nov 7, 2021

I think it is numpy/numpy@cd7a02a

@simonjayhawkins
Copy link
Member

@phofl duplicate of #44362?

@phofl
Copy link
Member Author

phofl commented Nov 9, 2021

The scipy part yes

@phofl phofl closed this Nov 9, 2021
@phofl phofl deleted the scipy_dev branch November 13, 2021 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI Continuous Integration Dependencies Required and optional dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phofl @jbrockmendel @simonjayhawkins